Add documentation for OIDC events in ASP.NET Core#706
Merged
Conversation
Introduced new documentation explaining OpenID Connect handler events in ASP.NET Core. Includes details on event triggers, common use cases, setup instructions, and customization examples to aid developers. #705
khalidabuhakmeh
added
documentation
maartenba
requested changes
May 2, 2025
Member
maartenba
left a comment
maartenba
left a comment
There was a problem hiding this comment.
Going with "request changes" to discuss a bit further.
- These events are really callbacks. Should we name them as such, or is this in line with MS docs?
- Does this need a diagram to show in the OIDC flow where/when these callbacks are made?
Comment on lines
+24
to
+25
| ```csharp | ||
| builder.Services.AddAuthentication(options => |
Member
There was a problem hiding this comment.
Suggested change
| ```csharp | |
| builder.Services.AddAuthentication(options => | |
| ```csharp | |
| // Program.cs | |
| builder.Services.AddAuthentication(options => |
…ents.md Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
…ents.md Co-authored-by: Maarten Balliauw <maarten.balliauw@duendesoftware.com>
Member
|
On second review, this looks goo to merge imo. Thanks @khalidabuhakmeh ! |
maartenba
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
#705